Design comparison
SolutionDesign
Solution retrospective
It is my first project on frontendmentor.io site and I would appreciate any feedback on my first project!
Community feedback
- @benjoquilarioPosted over 3 years ago
Congrats on this finishing your 1st frontend project.
Suggestion:
- Remove the
height: 100vh
on thebody tag
. Because this will only limit the body to have a height 100% of the remaining viewport or screen. 2 . Change the background color ofdiv="flex"
tobody
. - Remove or add code on the
div="container"
. Because you didn't any code on it basically it useless. 3.1. addmargin: 0 auto;
width: 1000px
or any pixel you want andmax-width:100%.
- Try add width: 100% on image.
Aside from those, really good job on this.
Marked as helpful1@AleksandraRyanPosted over 3 years ago@benjoquilario Thank you for your suggestions !
0 - Remove the
- @akash-1712Posted over 3 years ago
In mobile layout set width:initial for div.flex it allow to center the container horizontal.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord