Design comparison
SolutionDesign
Solution retrospective
What could I have done to have a more simplified code?
Community feedback
- @denieldenPosted over 2 years ago
Hi Daniel, good job!
For improve your code:
- to make it look as close to the design as possible add
text-align: center
tocard
class - remove all
margin
fromcard
class and body because with flex they are superfluous - remove
margin and padding
from html and body because with flex they are superfluous - add
justify-content: center
to body for center the card vertically - add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Overall you did well 😉
Hope this help and happy coding!
0@danielfrontendjourneyPosted over 2 years ago@denielden thanks a bunch for the feedback, will adjust this in the code.
Stay safe!
1 - to make it look as close to the design as possible add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord