Skip to content
Submitted almost 3 years ago

Fisrt time using Sass

murilo•110
@mlzzi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Article preview component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

First time using Sass. If you have some tips, please, be my guest.

I have one question. When I load the page I need to click two time to the share button to it pop up. Then, in the sequence clicks it work propely. Not sure why this is hapening, any guess?

Please, don't be shy and give me feedback :)

Thanks in advance!

Community feedback

  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    Hey good job on this challenge! Your report above shows a few issues. You can fix them by

    • wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here

    Hope this helps :)

    Marked as helpful
    1
    murilo•110
    @mlzziPosted almost 3 years ago

    @anoshaahmed Thanks

    I changed the HTML. The issue was that the attribution were a div tag, but I changed it to footer. Not sure if it is a footer. Haha But thank for your feedback.

    I really appreciated!

    1
    Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    @mlzzi yup semantics r more accessible

    0
  • Alex Li•400
    @awexliPosted almost 3 years ago

    Hi Murilo,

    Looking at your openShareIcons function. The reason why it doesn't open the first time is because by default share.style.display does not equal to "none", and so it will execute the else block.

    Marked as helpful
    1
    murilo•110
    @mlzziPosted almost 3 years ago

    @awexli Thanks Alex,

    I inverted the blocks conditions and now it works fine.

    Best regards!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord