first-solution using CSS Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 5 months ago

  Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  I Gladly welcome you to the Frontend Mentor Community, Happy Coding!

  0

  ---

  

  Mohanpradeep S•10

  @mohanpradeep-sPosted 5 months ago

  @0xabdulkhalid Hearty Thanks for your comment.I'll correct my mistake on upcoming tasks.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 5 months ago

  @mohanpradeep-s You're welcome!

  PS: Are you from Tamilnadu ?

  0

  

  Mohanpradeep S•10

  @mohanpradeep-sPosted 5 months ago

  @0xabdulkhalid yes sir and you?

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 5 months ago

  Mohan, You don't need to call me as "Sir".

  I'm a Student though, you can call me using my name.

  Naanum Tamil paiyan thaa Bro..

  0