Skip to content
Submitted about 2 years ago

First-Challenge QR_CODE

Amit Patre•30
@Amit9689
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @Amit9689, good job for completing this challenge! 👋

    Here are some suggestions to improve your code:

    • Add a <h1> tag in your solution, The <h1> element is the main heading in a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; always start from <h1>, followed by <h2> and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1>Improve your front-end skills by building projects</h1>

    • The color of the Paragraph element is unreadable because it is too light compared to its background, change the color to hsl(220deg, 15%, 55%) for example, and the h1 to hsl(218deg, 44%, 22%);

    • Try to use semantic tags in your code. More information here:

    Without semantic tags:

    <body>
   <div class="card">
   </div>
<body>

    With semantic tags:

    <body>
   <main class="card">
   </main>
<body>

    In the .card selector update width: 350px; to max-width: 350px; and add a margin of 15px

    • Update the image, This will make it resize when you view it on mobile devices:
    .card > img {
    max-width: 350px;
    width: 100%;
    object-fit: contain;
    border-radius: 15px;
}

    I hope those tips will help you.

    Good Job !

    Marked as helpful
    0
    Amit Patre•30
    @Amit9689Posted about 2 years ago

    @MelvinAguilar thank you for your valuable feedback i will update as soon as possible. thank you

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord