Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

First try with plain css

@GuillermoOM

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I was wondering about whether I did right for any kind of display size, just to be sure if its correct to use px sizes from time to time (for padding and margin for example)

Community feedback

Siege 520

@idesmar

Posted

Hi Guillermo! How was your first challenge with FEM? I hope you had fun.

On using px for sizes, I normally just use rem for most sizes even padding and margin. Some uses em on the latter two but then again that comes down to your preference. I might use px for very small details like outline or borders.

Regarding accessibility issues, you may want to look into using container tags like <header> <main> <section> <article> and <footer>. MDN is always a good source.

Marked as helpful

2

@GuillermoOM

Posted

@idesmar Thank you for your input and help!

I will def try out rem and em to experiment on those and see differences.

About the accessibility, it's def something I've never heard about but I'm glad I did and will try to apply it on my future projects from now on!

1
Siege 520

@idesmar

Posted

@GuillermoOM You're welcome. I remembered this video from Kevin Powell that got me using rem more and it explains a little bit as to why you should consider using it too. It's more of an intro to CSS units, in my opinion, because font/typography is a huge but interesting topic.

1

@GuillermoOM

Posted

@idesmar it certainly was an interesting watch, and seems to be a correct standard to use most of the time.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord