Frontend Mentor | First try on Mobile first approach using flex coding challenge solution

@PhoenixDev22

Posted over 2 years ago

Hello @Ma1021 ,

I have some suggestions regarding your solution:

First of all , there's an issue with the live site of your solution .
swap the buttons for anchor tags. Clicking those "learn more" buttons would trigger navigation not do an action so button elements would not be right. And for future, it is essential if you include a button in a form element without specifying it's just a regular button, it defaults to a submit button., though, so it's a good idea to make a habit of specifying the type.
you can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). and make the other heading tags to h2.

.sr-only {
	border: 0 !important;
	clip: rect(1px, 1px, 1px, 1px) !important;
	-webkit-clip-path: inset(50%) !important;
		clip-path: inset(50%) !important; 
	height: 1px !important;
	margin: -1px !important;
	overflow: hidden !important;
	padding: 0 !important;
	position: absolute !important;
	width: 1px !important;
	white-space: nowrap !important;            
}

border-radius and overflow hidden to the container that wraps the three cards.so you don't have to set it to individual corners.
never have font size in px.
You should use em and rem units .Both em and rem are flexible, scalable units. Using px won't allow the user to control the font size based on their needs.
line heights should be unit less For accessibility concerns

Overall , your solution is good . Hopefully this feedback helps

Marked as helpful

Maggie• 70

@Ma1021

Posted over 2 years ago

@PhoenixDev22

Thank your for the advice!

Live site was updated now.
Button was changed to anchor now. Understood that button's function is for form instead of going to other link <-- should be anchor instead
h1 with class="sr-only" <-- not familiar with the tag and the usage of the class so I went checked on why adding this class. Why use sr-only

Reading the information in https://getbootstrap.com/docs/3.4/css/, I guess the use of sr-only class is to allow the screen reader to read. But why h1 need to add in this class? h1 tag should be shown instead of hidden I guess?

4.Thank you for this one! I have applied it and the code is cleaner.

I used 15px directly because css guide state the body font size is 15px. But after your advice, it turns out that using rem would be more flexible while using different device. The default html font size are different on different devices! Different font size in different browser
Line height should be unit less as they are multiplier of the font size (with unit).

Thank you again for your suggestion!

PhoenixDev22• 16,950

@PhoenixDev22

Posted over 2 years ago

@Ma1021 I’m glad that it was beneficial . For question about <h1> it is recommended not to have more than one h1 on the page .

First try on Mobile first approach using flex

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community