first time using sass

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, @rorozoamuhammad! 👋

  You can try using Regular Expressions (RegEx) to validate all the input values. I had done this challenge and I had written an explanation about the RegEx that I used. So, feel free to visit my solution. You can ask me any questions regarding the validation. 😉

  Some feedback from me.

  • header element should not be used here. header is used to to wrap the internal navigation links and often it also contains the logo of the website. So, change the header element to div element.
  • Always specify the type of the button. In this case, set the type of them as type="submit". It's going to prevent the button from behaving unexpectedly.
  • The "Try it free 7 days then $20/mo. thereafter" is not an interactive element. It is just a text (no link).
  • There's an empty script tag. So, I recommend removing it since it can confuse other developers (including yourself in the future). (But, I assume that it will be used for the validation.)
  • Don't nest too much in the Sass files. They produce a high specificity CSS. This is something that I also did when I first started using Sass. When I came back to refactor it, I had no idea what was going on. As a result, I decided to start over. So to prevent it, I recommend only nesting when you want to style pseudo-elements, pseudo-classes (:hover, :focus, etc), and @media queries.

  That's it! Hope this helps.

  P.S. I am an Indonesian. Saya tinggal di Lampung. Salam kenal! 👋

  0