Design comparison
Solution retrospective
My first time doing React & I could use a lot of help.
Admittedly, I don't really know what I'm doing still but I decided to try some project based learning (and some help from YouTube).
If you know React & could add any input please help me!!!
Also, I used SCSS with this project... is it good to use sass w. React?
Community feedback
- @MarkoNikolajevicPosted over 4 years ago
As your first time using React you did it really really damn good! Your code is clear and readable! You create a JobBoard component and you render all jobs looping with this component. I always use sass with React. I don't have else to say except that you really did a great work with this.
2@DiarrahPosted over 4 years ago@MarkoNikolajevic wow thanks so much for the kind words!
0 - @rfilenkoPosted over 4 years ago
Hey, it's ok to use sass with react, there some different solutions like css-in-js (popular styled components, for example), but those are more advanced and overkill for this project. A few tips for you:
- don't mutate state directly in react (saw push method in your code);
- probably don't make dots as li items, make them as pseudo elements;
- maybe add some transitions to selecting/ deleting tags. Also layout moves, when .job-requirements div appears.
Other challenge for you would be to make dynamic jobdetails pages with addition of router between pages 😉.
Roman
0@DiarrahPosted over 4 years ago@rfilenko thanks so much! I will try to revise the code to take that push method out.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord