Skip to content
Submitted almost 2 years ago

first task

yamenmaani•30
@yamenmaani
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

this is a test for the first task I hope I can improve my codding and my comments writing ;)

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    Hi, there! 👋

    Congratulations on finishing your first Frontend Mentor challenge! 🎉

    Here are a few things you can do to improve this solution.

    • Fix all the issues that have been reported.
    • The QR code is not a decorative image. So, it should have alternative text.
    • Make sure the alternative text describes the purpose of the QR code.
    • Decrease the size of the card to make your solution looks closer to the design.
    • The card only needs a max-width to prevent it from becoming too large while still allowing it to shrink if ever needed.
    • Use the <body> element as the container of the card. You don't need to an extra <div>. In fact, you don't need to use <div> elements to create the site. Keep the HTML markup as simple as possible.
    • Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset | Andy Bell

    I hope this helps. Happy coding! 😄

    0
    yamenmaani•30
    @yamenmaaniPosted over 1 year ago

    @vanzasetia thank you so much

    0
    Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    @yamenmaani

    You are welcome!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord