@danielmrz-dev
Posted
Hello @BekiaD!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body {
min-height: 100vh;
display: flex; /* it works with grid too */
justify-content: center;
align-items: center;
}
- Using tailwind, that would be
<body class="min-h-screen flex justify-center items-center">
.
I hope it helps!
Other than that, great job!
Marked as helpful
@BekiaD
Posted
Hi @danielmrz-dev , I appreciate you taking the time to once again review my code.
I added the modifications to the body, but I am not sure which margins should I remove, as there were none on the body? It would be helpful if you could clarify that part, but either way thanks :)
@danielmrz-dev
Posted
@BekiaD
I mean the .my-20
that you added to the container š
Marked as helpful