Design comparison
Solution retrospective
(update for the learning path)
What challenges did you encounter, and how did you overcome them?(update for the learning path)
What specific areas of your project would you like help with?(update for the learning path)
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @BekiaD!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
- Using tailwind, that would be
<body class="min-h-screen flex justify-center items-center">
.
I hope it helps!
Other than that, great job!
Marked as helpful1@BekiaDPosted 10 months agoHi @danielmrz-dev , I appreciate you taking the time to once again review my code.
I added the modifications to the body, but I am not sure which margins should I remove, as there were none on the body? It would be helpful if you could clarify that part, but either way thanks :)
1@danielmrz-devPosted 10 months ago@BekiaD
I mean the
.my-20
that you added to the container šMarked as helpful1 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord