First styled-components project

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Adler, congrats on this submission and working with styled components! Quite enviable to finish a guru challenge :-) Won't comment on React since I'm still learning, but it would be nice to have it handle the form submission. Seems to be using native validation for now.

  • With RWD, the smaller to mid screen sizes could be cleaned up a bit more. I noticed horizontal scrollbars and overlapping content on different pages - check out the project at 830px as an example.

  • Regarding accessibility: The buttons are better with their outlines for keyboard users.

  • Other minor stuff is the countries info on the contact page and the CTA section and are missing their circle backgrounds. And the social media icons could use hover states.

  Hope this helps!

  1

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @emestabillo Thank you for taking the time to write this detailed review. I got lazy and did not do the background things and the hover part for the icons. 😬😬😬😬 I'm planning to make updates today, were there anything else I missed?

  1

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  @adluders Haha. Not sure there's anything else but maybe you can also address the issues in the report since you're there :-)

  1

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @emestabillo 😩 😩 😩 😩 I was hoping you'd say no. but now the report too!! 😩 😩 😩 I shall get them done today or tomorrow though

  1