Skip to content
Submitted over 3 years ago

First styled-components project

Adler G Ludersā€¢1,580
@just-a-devguy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Designo multi-page website
  • HTML
  • CSS
  • JS
5guru

Design comparison

SolutionDesign

Solution retrospective

I decided to use this project as a way to learn and work with styled components for the first time. I gotta say not the smartest idea I had but I managed my way around completing it. Please, please leave any feedback on ways I can improve. Also, if anyone knows how to deal with environmental variables in netlify, please help. I tried to the map section with Mapbox, got it to work locally but it would not work on Netlify. As always, #HappyCoding

Community feedback

  • Emmilie Estabilloā€¢5,540
    @emestabilloPosted over 3 years ago

    Hey Adler, congrats on this submission and working with styled components! Quite enviable to finish a guru challenge :-) Won't comment on React since I'm still learning, but it would be nice to have it handle the form submission. Seems to be using native validation for now.

    • With RWD, the smaller to mid screen sizes could be cleaned up a bit more. I noticed horizontal scrollbars and overlapping content on different pages - check out the project at 830px as an example.

    • Regarding accessibility: The buttons are better with their outlines for keyboard users.

    • Other minor stuff is the countries info on the contact page and the CTA section and are missing their circle backgrounds. And the social media icons could use hover states.

    Hope this helps!

    1
    Adler G Ludersā€¢1,580
    @just-a-devguyPosted over 3 years ago

    @emestabillo Thank you for taking the time to write this detailed review. I got lazy and did not do the background things and the hover part for the icons. šŸ˜¬šŸ˜¬šŸ˜¬šŸ˜¬ I'm planning to make updates today, were there anything else I missed?

    1
    Emmilie Estabilloā€¢5,540
    @emestabilloPosted over 3 years ago

    @adluders Haha. Not sure there's anything else but maybe you can also address the issues in the report since you're there :-)

    1
    Adler G Ludersā€¢1,580
    @just-a-devguyPosted over 3 years ago

    @emestabillo šŸ˜© šŸ˜© šŸ˜© šŸ˜© I was hoping you'd say no. but now the report too!! šŸ˜© šŸ˜© šŸ˜© I shall get them done today or tomorrow though

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord