Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

First QR code

@LeonardoSchuquel

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas πŸ‘Ύβ€’ 104,420

@correlucas

Posted

πŸ‘ΎHello Leonardo, congratulations for your new solution!

Your component card its really good done. But you can do some work around the html structure in order to have a cleaner code. For example, you can replace the div with the <main> tag. Remove all the other divs and wrap everything just with a single block, in this case the main.

To clean the css you can remove all the classes and manage everything just by using the direct selector for each element (main, div, h1, img and p).

To have a better perfomance with the image scaling use ever display: block and max-width: 100% to have the image scaling with the container size.

πŸ‘‹ I hope this helps you and happy coding!

Marked as helpful

0

@LeonardoSchuquel

Posted

@correlucas @correlucas Hi @correlucas thanks for the feedback. It was very useful for me and I have already applied the changes

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord