First project using flexbox,position and box modeling

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello, kawaiiakuma! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Good job on this one! 👏

  A few things I'd like to suggest are,

  • Using some more semantic HTML elements in your solution, rather than just div elements for everything. You can use a p element for the description and a heading element for the title of the card, for instance. If you'd like to learn more about semantic HTML and why it is important, check this out.
  • Setting the alt text for icons in this challenge to an empty string so that they will be ignored by screen readers. That's because those icons aren't really necessary or important for the content of the page and therefore do not need to be read by screen readers. You might want to add some more descriptive text for the alt attribute of the main image, though, since that text will be read by screen readers, so it's important to make sure that it makes sense to users who will be navigating your page with those tools. 😉

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  kawaiiakuma•130

  @nirvayathapaPosted over 2 years ago

  @ApplePieGiraffe Thanks u so much sir!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @nirvayathapa

  Happy to help! 😀

  1