First Project using Flexbox + Resposive layout
Design comparison
Solution retrospective
I would like feedback in the CSS code, and in the HTML sintax, please!
Community feedback
- @mattstuddertPosted over 4 years ago
Hey Diego, nice work on this challenge. Here are some pointers after taking a look at your solution:
- In the first block, you're using a
ul
, whereas I'd just say that those are two paragraphs. You're also usingdt
to close theli
elements, which will cause issues in certain browsers. - You're then using a
dl
in the second block, where again I'd say these would be simple paragraphs or spans. Here's the MDN article on description lists to learn more about where you might use thedl
element.
I hope this helps. Keep up the great work!
0@diegomouradevPosted over 4 years ago@mattstuddert Hey Matt. Thank you for the feedback. I was overthinking the syntax of the Html indeed. I have the wrong idea that I should avoid divs and spans at all costs, but on projects like this, where we don't have the other parts of the content, they are indispensable, I concluded. I'm focusing on reading about it so that I can mark it appropriately.
0@mattstuddertPosted over 4 years ago@diegomouradev sounds good! Yeah,
div
andspan
elements are an essential part of HTML. So definitely don't try avoiding them! 👍0 - In the first block, you're using a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord