Design comparison
Solution retrospective
I'm proud of this being my first project on Frontend Mentor, I plan to add more features to the project in the later future
What challenges did you encounter, and how did you overcome them?Just how to give an image a border radius
What specific areas of your project would you like help with?None so far
Community feedback
- @correlucasPosted about 2 years ago
๐พHi @jtsenpai, congratulations on your solution!๐ Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw youโre on the right track. Iโve few suggestions for you that you can consider adding to your code:
- Use
<main>
instead of a simple<div>
this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a<main>
block and that<div>
doesn't have any semantic meaning. - Use relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well. - The correct value for this shadow is
box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0@jtsenpaiPosted about 2 years ago@correlucas Thank you for the suggestion. I'll use it for other projects as well. Thanks again
0 - Use
- @DeolabestPosted about 2 years ago
Hey Jesutoni, Congratulations on completing this challenge!
Here is my feedback:
-
I'll suggest you reduce the font of heading and increase that of the description to match the project's task.
-
The project is not meant to extend beyond the page. Try to reduce this margin-bottom: 8px;
Keep doing a good job!
0@jtsenpaiPosted about 2 years ago@Deolabest Thank you for the feedback really means a lot
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord