QR Code Component using HTML and CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @jtsenpai, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
  • The correct value for this shadow is box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Jesutoni•80

  @jtsenpaiPosted about 2 years ago

  @correlucas Thank you for the suggestion. I'll use it for other projects as well. Thanks again

  0
• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey Jesutoni, Congratulations on completing this challenge!

  Here is my feedback:

  1. I'll suggest you reduce the font of heading and increase that of the description to match the project's task.

  2. The project is not meant to extend beyond the page. Try to reduce this margin-bottom: 8px;

  Keep doing a good job!

  0

  ---

  

  Jesutoni•80

  @jtsenpaiPosted about 2 years ago

  @Deolabest Thank you for the feedback really means a lot

  0