Skip to content
Submitted over 2 years ago

first project

AhmedAlasyotY•110
@Ahmed666313
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Are there any mistakes in code configuration that I'm happy with the answers?

Community feedback

  • Naveen Gumaste•10,480
    @NaveenGumastePosted over 2 years ago

    Hello Ahmed666313 ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    First of all i suggest using external CSS means Style.css file for the styling its will be easy to maintain

    • Add Main tag after body
    <body>
<main class="container">
*all you content here*
</main>
</body>

    • -> Check my article on accessibility issues

    • Background color should be matching to the original design and i believe they have given the color in style-guide so refer that

    • Give the border-radius to the QR img too, the title color i believe is dark blueish color given in style-guide

    happy Coding😀

    Marked as helpful
    0
  • AhmedAlasyotY•110
    @Ahmed666313Posted over 2 years ago

    Thank you Naveen, this is what I am working on in the challenges ahead, God willing

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord