A pixel perfect solution to this project well almost

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @AReactDeveloper

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Use of semantic HTML elements

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • You don't need width: 100vw on your body. block elements already take up the full width of their parent by default.

  • Try using relative CSS values like rem and em.

  • I suggest not setting a fixed width and height on an element because you will run into overflow issues. A height of auto is fine, which block elements already are by default.

  • Try making your solution responsive.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1

  ---

  

  AReactDeveloper•340

  @AReactDeveloperPosted 4 months ago

  @DylandeBruijn Thank you so much for your golden advices i can tell they came out of experience
  i did try rem em but i was lazy didn't open a converter cause i was trying to get the design as close as possible the comment was very helpful actually thank you ill take this points with me in the next challenge thank you for taking the time to advise me regards

  0