First Mobile - QR Code Component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 7 months ago

  Hello @FaheedFis!

  Your solution looks great!

  I have a suggestion for improvement:

  📌 Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  1
• 

  Faheed Sadique•10

  @FaheedFisPosted 7 months ago

  thank you very for the tips

  0
• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 7 months ago

  Hey Faheed, good job!

  Here is my feedback - I hope it helps :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap .container in a <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor website).

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport. Remove the margin.

  • Remove the width on the card.

  • Give the card max-width: 20rem to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • It is common to add display: block to images, in addition to the max-width: 100% you have already added.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem, not px.

  0