First junior proyect. Time tracker dashboard

Community feedback

• 

  Doston Nabotov•950

  @dostonnabotovPosted over 1 year ago

  Hey, there! 👋

  Congrats on your first junior challenge solution. Here's some suggestions I would like to point out:

  • The cards didn't load on the page. I think it has to do with your JavaScript fetching code.
  • Opt for better naming convention for your classes. Since div-small, div-violet doesn't carry too much meaning, go with something like card, tracking-item and etc.
  • Also, I would avoid spamming <br> elements to give space between other elements. You can read more about its purpose on MDN Docs
  • CSS custom properties woud really help optimize your CSS code.
  • As the last suggestion, I would recommend reading and following the Frontend Mentor guidelines. Create a README.md file and explain what, how and why you did. Good for you and other fellow programmers.

  Hope it helps! Good luck on your coding journey!

  Marked as helpful

  0

  ---

  

  ElisaFossemale•40

  @ElisaFossemalePosted over 1 year ago

  @dostonnabotov Hi, thank you for yor feedback! Really helps me! I'm always struggling whit class names, great tip. If you press the card whit the name and the img, doesn´t work? I should have warned that.

  Eli

  0