First frontendmentor challenge made by me

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  This is a pretty awesome solution, I like it! All I can do is just to address your accessibility issues.

  1. It's not advisable to have more than one main landmark (it can only be one). You should consider using a section or article thereafter.
  2. You should always have a level one heading tag (h1) in your website, it's a good practice.. It will also help you avoid more accessibility problems when you submit other solutions in the future.
  3. You should also make sure that all your page content is contained within a landmark.. It makes it easy for people with screen readers to navigate your code. Otherwise this is a very good solution! Kudos! I believe you can become the best web dev😎Keep on coding!

  Marked as helpful

  1
• 

  T

  Mike Hayden•1,005

  @mickygingerPosted about 3 years ago

  Hey Luisana!

  This looks really good, and I agree with @civisky, centering the component would be a nice touch.

  You can do that using flexbox, something like:

  body {
      margin: 0; /* remove the annoying margin added by the browser */
      height: 100vh; /* set the height to match the viewport height */
      display: flex;
      flex-direction: column; /* make sure the footer sits below the content */
      justify-content: center; /* center the contents vertically */
  }
  

  Hope that helps!

  Marked as helpful

  0
• 

  Fury•945

  @ashiqfuryPosted about 3 years ago

  Excellent work.

  • you are using margin-left and margin-right properties. Instead of this, use margin: 0 auto to center anything.
  • try to use some shorthand properties, it brings your code clean.

  Thank you.

  Marked as helpful

  0
• 

  Olaniyi Isaac•15

  @civiskyPosted about 3 years ago

  great work Ivisana! maybe you could try positioning the card at the centre of the display/screen. Nice work there!!!

  Marked as helpful

  0
• 

  Luisana•70

  @lvisanaPosted about 3 years ago

  Thank you all so so so much <3

  0