Skip to content
Submitted 8 months ago

First Frontend Mentor Challenge, VS code

Steven Stroud•11,910
@Stroudy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This is the second time i have written this, second time i went back to use different units to make it even more responsive.

What challenges did you encounter, and how did you overcome them?

Was still learning Flexbox and how the boxes work at a fundamental level.

What specific areas of your project would you like help with?

Anything i can do to improve, I am all ears so please tell me what i could do better?

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @Stroudy ,

    I think you can prefer to replace <div class="qr-container"> with <main> element as it will improve accessibility.

    Also, you can use Flexbox for centering the card.

    Hope these suggestions are helpful !

    Happy Coding !

    1
    Steven Stroud•11,910
    @StroudyPosted 8 months ago

    @Harsh-Kumar-Dwivedi Thank you i will do that now appreciate the help, I could not figure out how to center using Flexbox so i settled with margin-inline.

    0
    Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Stroudy

    Kindly, Please refer to my below separate post.

    If you find my suggestions helpful, kindly, please consider marking them as "Marked as helpful".

    Stay Happy & Healthy !

    Happy Coding ! 😀

    0
  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Stroudy

    Welcome !

    I think you should apply following code in style.css:-

    body {
display: flex;
justify-content: center;
align-items: center;
}

    Also, remove these margin-inline: auto;, margin-top: 9.5rem; from qr-container class.

    These should center the card. If not, try inspecting the webpage using chrome dev tools it will help you to find any issues quickly.

    If you find my suggestions helpful, kindly, please consider marking them as "Marked as helpful".

    Stay Happy & Healthy !

    Happy Coding ! 😀

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord