Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

first front-end mentor challenge

@Basma-Bensadi

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@rathoddharmendra

Posted

I really liked that you use multiple divs to manage each group better. Few of the improvements I noticed are:

  • Using sizing on image twice - once as img attribute and on img selector in CSS
  • missed to add color: grey on class="text"
  • suggestion: using relative sizing like percentage or rem is better for responsiveness overall than px

As I said, overall the code works really good. I hope my review helps you :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord