First ever responsive QR code Component using HTML CSS

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 1 month ago

  Hi Mohammed, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem!

  link -> px to rem

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  The rest is amazing.

  I hope this is helpful. 👍

  Marked as helpful

  0

  ---

  

  Mohammed•50

  @Mohammed-morsiwalaPosted about 1 month ago

  @AdrianoEscarabote thanks for your amazing feedback I always think of using the rem instead of px with ur given reference it's already super easy and also on my second project I will try to use ur advice and suggestion and 1 more thing if someone mark ur feedback helpful u get 20points no worries I already did 😀.

  1

  

  Adriano•38,330

  @AdrianoEscarabotePosted about 1 month ago

  @Mohammed-morsiwala hahahh thanks man !

  0