first challenge with bootstrap 4

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Hi Mohammed, great work on this challenge and congratulations on submitting your first solution! What specifically would you like to get feedback on?

  As far as your HTML goes, I've got a couple of suggestions:

  • I'd recommend taking a look into using HTML5 structural elements to replace some of your div tags. Here's a great MDN article of adding structure to the page.
  • You're currently using h2 and h5 heading elements, but no h1, h3 or h4. I'd recommend always having a single h1 on the page. This marks out the main page title. Also, I'd recommend not skipping heading levels unnecessarily, as this can cause accessibility issues for people using screen readers.

  I hope these tips help. Let me know if you have any questions! 🙂

  3

  ---

  

  Mohammed Abd Alrazaq•1,966

  @MOHAMMED-ABD-RAZAQPosted about 5 years ago

  thanks

  4