First challenge - QR code component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 8 months ago

  Hello, @vonsacker!

  Your project is looking fantastic!

  I'd like to suggest a way to make it even better:

  • Using margin isn't always the most effective method for centering an element.

  Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

  📌 Apply this CSS to the body (avoid using position or margins in order to work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  About using flexbox or grid:

  📌 Use flexbox when you need a one-dimensional layout (either in a row or a column), such as navigation menus or arranging items within a container.

  📌Use CSS grid when you need a two-dimensional layout with rows and columns, like organizing content in a grid-like structure or creating complex layouts.

  In simple terms, use flexbox for simpler, linear layouts and CSS grid for more complex, grid-based layouts.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  1
• 

  Huy Phan•2,060

  @huyphan2210Posted 8 months ago

  Hi vonsacker,

  If this is the first front end challenge you've ever done, good job.

  I want to make some suggestions:

  Make the body css like this:

  body {

  min-height: 100vh; // Make the body at least fills the whole page

  margin: 0; // Remove the default margin of the body

  // Other values here

  }

  Then you can use flexbox or grid to make the card in the center.

  And if you can, use as less fixed numbers (like 300px, 480px, etc.) as possible. Try to play with percentage. Devices have different widths, so I think this is a better way

  Marked as helpful

  1