first challenge Qr code component

Community feedback

• 

  Buchi•160

  @B-uchiPosted over 2 years ago

  Congratulations @oussamaelhousni on completing your first challenge, your solution looks really nice. Here are a few things I noticed:

  • You didn't add a box-shadow to your .container div.
  • Although I wont count myself as an expert, I don't really think it was necessary to include your CSS styling directly in the HTML file. I believe it's good practice to have external CSS linked to your HTML file.

  Apart from these few things, your solution was spot on!! Cheers

  0

  ---

  

  Oussama Elhousni•190

  @oussamaelhousniPosted over 2 years ago

  @B-uchi thank you buchi for your note i just want to reduce the number of files because the challenge is simple

  0