Design comparison
Solution retrospective
All feedback is welcome! I can use it to gain more knowledge and improve my skills.
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi!
First, remove all the
br
elements. Screen readers will read outbr
elements as "break". Let lines wrap where they need to.Then, use a heading tag instead of a
p
withid="main-heading"
.Lastly, always use classes to reference all the elements you want to style. Using
id
will make your stylesheet have high specificity (hard to maintain). As a side note, ideally,id
should be used for anchoring.I hope this helps!
Marked as helpful0@ALAS08Posted about 2 years ago@vanzasetia
Hello!
Thank you for your feedback!
It is very helpful since I'm still not familiar on how and when should I use the id and class attributes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord