Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

First Challenge - QR Code

ALAS 30

@ALAS08

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcome! I can use it to gain more knowledge and improve my skills.

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi!

First, remove all the br elements. Screen readers will read out br elements as "break". Let lines wrap where they need to.

Then, use a heading tag instead of a p with id="main-heading".

Lastly, always use classes to reference all the elements you want to style. Using id will make your stylesheet have high specificity (hard to maintain). As a side note, ideally, id should be used for anchoring.

I hope this helps!

Marked as helpful

0

ALAS 30

@ALAS08

Posted

@vanzasetia

Hello!

Thank you for your feedback!

It is very helpful since I'm still not familiar on how and when should I use the id and class attributes.

0
Vanza Setia 27,795

@vanzasetia

Posted

@ALAS08 Happy to hear that was helpful! 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord