First Challenge I have tried - Four Card Feature

Community feedback

• 

  Darryl•155

  @DJH-devPosted about 5 years ago

  Great Job the site looks good and the code is nice and readable. Only thing I would add is maybe trying to use some of the HTML5 semantic elements like header and section instead of div in some places but that is subjective. Great Job

  2
• 

  Solomon Ekrebe•610

  @krebeDevPosted about 5 years ago

  Your work is clean and beautiful. However, in addition to the HTML5 semantic elements already suggested by DJH-dev, you should have used tags like headings (h1,..h6) and <p> for accessibility.

  1
• 

  TheInstantiator•60

  @TheInstantiatorPosted about 5 years ago

  Thanks all for the feedback, after I submitted and took another look, I did think to myself why I didn't use any headings and p tags.

  0
• Account deleted

  just complete all challenges and u will see the difference .. looks great work bro ..

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @DJH-dev and @krebeDev have given some great feedback, so I've got nothing more to add other than to say well done and congrats on submitting your first solution! 🙂

  0
• 

  TheInstantiator•60

  @TheInstantiatorPosted about 5 years ago

  Thanks for the feedback, I will take a look at those elements.

  0