First Challenge Completion using HTML and CSS

Community feedback

• 

  Declan•320

  @engelbrechtzPosted about 2 years ago

  Hey, how's it going?

  This is really well done. Good job!

  A small change that you can do next time would be to, Create a separate file called style.css and link it to you're HTML using <link rel="stylesheet" href="style.css" />

  Using the style tag can make the HTML file long and difficult to read having to scroll back to review the code. It's clean to keep them separated, it makes it easier to read and write CSS.

  My second piece of advice would be to use the root element in CSS. This is how you can use variables to save CSS colours instead of copying and pasting the same hex code.

  :root{ --colour-of-box: white; }

  You can review my code on GitHub. My Code.

  Overall, everything seems to be perfect!! keep it up.

  0

  ---

  

  Fahad Nawaz•20

  @Fahadnawaz007Posted about 2 years ago

  @DevDeclann Thanks Brother I highly appreciate your advice.

  1