Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

First Challenge Completion using HTML and CSS

@Fahadnawaz007

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


An ideal feedback about my solution would be very very appreciated. And will be very useful for me.

Community feedback

Declan 220

@engelbrechtz

Posted

Hey, how's it going?

This is really well done. Good job!

A small change that you can do next time would be to, Create a separate file called style.css and link it to you're HTML using <link rel="stylesheet" href="style.css" />

Using the style tag can make the HTML file long and difficult to read having to scroll back to review the code. It's clean to keep them separated, it makes it easier to read and write CSS.

My second piece of advice would be to use the root element in CSS. This is how you can use variables to save CSS colours instead of copying and pasting the same hex code.

:root{ --colour-of-box: white; }

You can review my code on GitHub. My Code.

Overall, everything seems to be perfect!! keep it up.

0

@Fahadnawaz007

Posted

@DevDeclann Thanks Brother I highly appreciate your advice.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord