First Challenge! Completed with the Handy Flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Jordan, Congratulations on completing this challenge!

  1.Add the correct size to avoid the container growing more than it should. In this case the QR CODE component size is max-width: 320px.

  2.You’ve used <div> to wrap the card container, in this case you need to use <main> since this is the main block of this page.

  3.You’ve used px as the unit for sizes but the problem with pixels is that its not optimized for multiple devices and screens. So a good fit its to use rem or em that have a better performance and make your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Laharl•1,000

  @UrbanskiDevPosted about 2 years ago

  Hello Jordan Kisiel !

  Congratulation for finishing this project

  To answer your question, there is nothing with using pixel values everywhere, but it is not the best units to use for every properties.

  I have some links to help you learn more about the subject : -Medium CSS Which units to use

  • Github CSS Units

  I hope it helps you to answer your question

  Marked as helpful

  0

  ---

  

  Jordan Kisiel•250

  @JordanKisielPosted about 2 years ago

  @UrbanskiDev Thank you very much!

  0
• 

  Ayoife•300

  @AyoifePosted about 2 years ago

  Wow!!, This is the first solution for this challenge I've seen that matches the design perfectly and you did it without Figma right?!!, Nice work!

  0

  ---

  

  Jordan Kisiel•250

  @JordanKisielPosted about 2 years ago

  @Ayoife I did! Thanks for the encouragement!

  0