Skip to content
Submitted 12 months ago

First Challenge (built with React and SASS)

Scott Ning•170
@ning-sy210
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I completed this challenge months ago and never really thought about submitting it until now. This challenge itself doesn't really have much to go over, so I am looking for any general comments for areas that can be improved upon. For example (but not limited to the following):

  • Were the html tags used semantically appropriate?
  • How can the CSS be structured better?

Community feedback

  • Bryan Li•3,530
    @Zy8712Posted 12 months ago

    Your website look great. Good job!!

    The only thing I feel like you should change is to use <h1> tags for the title of the component instead of the <p> that you are using right now. The main reason being that screen readers may look for header tags, which your site is missing right now.

    Aside from that your code is well formatted and easy to follow along. Great work 👍

    Marked as helpful
    1
    Scott Ning•170
    @ning-sy210Posted 12 months ago

    @Zy8712 Hey Bryan, thanks for stopping by and leaving a comment! I thought about using the <h1> tag for the bold text but didn't know if it was appropriate or not. So ultimately I just settled with using a <p> tag instead. But I will make a note for my future challenges!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord