Finally finished Profile Card Component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi,

  This looks pretty good, you should be pleased with it. And you are right this challenge is a lot harder than it looks!

  A few points for you

  • only meaningful images need alt descriptions. Decorative images like the pattern at the top of the card should have empty alt attributes like alt="" so assistive technology knows not to announce them.
  • the hr you've used doesn't quite look the right color or thickness maybe. You could use a border bottom/top instead of the HR
  • the stats at the bottom need to be dead with the numbers and words together, and words like 'followers' aren't supplementary. They are core to to the meaning, so shouldn't be inside small tags. It would be better if these number-word pairs were in one paragraph together, with spans wrapping each part for styling. Or, you could probably use description-list elements which are well suited for this kind of content.
  • with css try to use classes, not ids for styling. IDs are a bad habit to get into for styling or javascript hooks, so best not to form that habit now. Keep specificity nice and low in your css by using single class selectors, that's what they are there for.

  Final recommendation is to take another look at your background images (those Circles). They are looking stretched/squished at most screen sizes.

  Keep on coding! Hope this all helps.

  1

  ---

  

  Abhijit Sarode•90

  @AbhijitSarodePosted over 3 years ago

  Hi @grace-snow,

  Considering from where I have started I am happy with myself but there's a long way to go.

  Your pointers definitely help, thanks a lot for taking out time and carefully going through my code. I will make suggested changes in my code and keep applying them in my future projects too.

  Again thanks a lot for your input. Really appreciate it

  0
• 

  kotesh_dev•0

  @kotesh-aryaPosted over 3 years ago

  hey mate, that looks pretty good but while viewing it in mobile those bubbles are getting combined with each other . Do check it once, rest are perfect 👍🏼

  0

  ---

  

  Abhijit Sarode•90

  @AbhijitSarodePosted over 3 years ago

  Hi @kotesh-arya,

  Thanks a lot. I will definitely look into it

  0