Fifth challenge ! The last at the "newbie" level for me

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Florian Pereira! 👋

  Your solution looks great and responds well! 👏

  I'm happy to hear this is your last "Newbie" challenge! Look forward to seeing more, as well! 😆

  Simply follow brasspetal's helpful suggestions to clear up your solution report and you should be good to go! 👍

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Florian Pereira•320

  @FloPereira75Posted almost 4 years ago

  @ApplePieGiraffe Thank you ! I'll take care of it right away. And we're off to a new week of code!

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted almost 4 years ago

  Hi, Florian!

  To clear up the errors in your report:

  • add an aria-label to your email input
  • add titles to your svgs. Ex: <svg <title>facbook</title> ...rest of svg file...

  Overall your solution looks great and responds pretty well, but I did notice some slight issues. While using percentages for responsiveness is great, I suggest also pairing it with max-width and/or clamp(). The margins get oddly stretched on tablet views between the header, text, and input, and the padding around the email and button gets very big on larger screens (ex: 1920px). Other than that your solution really is good, and I'm looking forward to seeing your junior challenges! Happy coding!

  1

  ---

  

  Florian Pereira•320

  @FloPereira75Posted almost 4 years ago

  @brasspetals Thanks for the time taken and the feedback! Very cool, I told myself that it was not normal that I have such big margins haha. I have a small screen (less than 1400px) so I never really know if I have set the right margins / padding! So I will take care of the mods that you recommend me! thanks again

  0