Submitted over 1 year ago
fetch API, button relative position, box-shadow glow onhover
@michaelbulaongdev
Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div id="root">
with semantic element<main>
to improve accessibility and organization of your page.
CSS 🎨:
-
To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📙. -
The
body
needs to have amin-height: 100vh
, and try to implement the below css styles to see changes
body { min-height: 100vh; display: grid; place-items: center; margin: 0; }
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - @michaelbulaongdevPosted over 1 year ago
Thank you for this. I will try these out.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord