Design comparison
Community feedback
- @isprutfromuaPosted over 2 years ago
Hi there. You did a good job 😎
keep improving your programming skills🛠️
your solution looks great, however, if you want to improve it, you can fix these points:
✅ pay attention to the automatic report on your solution. you need to fix html and a11y errors
✅ don't place script tag at the start of the body. Move it to the end to prevent page rendering blocking
✅ you can simply use picture tag to show it on mobile/desktop without css
<div> <img class="card__imgDesk" src="./images/pattern-divider-desktop.svg" alt=""> <img class="card__imgMob" src="./images/pattern-divider-mobile.svg" alt=""> </div>
I hope my feedback will be helpful. You can mark it as useful if so 👍
Good luck and fun coding 🤝⌨️
Marked as helpful0@M1guelHPosted over 2 years ago@isprutfromua I really appreciate your comments, they were totally useful.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord