FEM-qr-code-component-main

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add this single following rule to properly center the component.

  ---

  body {
  min-height: 100vh;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
  margin-top: 40px;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Dusvy_M•390

  @dovelmPosted over 1 year ago

  @0xAbdulKhalid thanks you!!

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @dusvimarin Glad you found it helpful ! 🤠

  0
• 

  Goran Malić•260

  @floatingPebblePosted over 1 year ago

  Looks great and clean!

  Maybe you should consider deleting their footer thingy and flex-direction: column and the top container's margin-top in order for centering to work. Their footer/author stuff will only make it hard to align your solution with their footerless design.

  Cheers, and happy coding!

  0

  ---

  

  Dusvy_M•390

  @dovelmPosted over 1 year ago

  @floatingPebble thanks for you comment

  0