FEM-order-summary-component

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Layout in general looks great and it is responsive.

  kens_visuals already gave great tips on this one, just going to add some suggestions as well:

  • The vector image is just a decoration so you can hide it. Decorative image must be hidden at all times by using alt="" and extra aria-hidden="true" attribute on the img tag.
  • Same goes for the music-icon, it is only decorative.
  • Also when using alt attribute, avoid using words that relates to "graphic" such as "icon" and others. An img is already an image/graphic so no need to describe it as one.

  Just those ones, to be honest this is a really great site. Markup looks great just the images.

  Marked as helpful

  0
• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @dusvimarin 👋🏻

  I just have some quick tips for the project 🙃

  • Since you already have transition for the button, I'd recommend adding it to the .links as well.
  • Also, for the music icon, add aria-hidden="true", because it's for decoration. You can read more about aria-hidden here.

  I hope this was helpful 👨🏻‍💻 congrats on the first project. You did a great job, well done. Cheers 👾

  Marked as helpful

  0
• 

  Dusvy_M•390

  @dovelmPosted about 3 years ago

  Raymart, thanks, thanks!!! and you're right about the names of images ... I did not know how to name it!!! ☺️

  1
• 

  Dusvy_M•390

  @dovelmPosted about 3 years ago

  Hi Kens, Thanks!!! 👍 I will make these changes ✋

  0