Design comparison
Solution retrospective
Hi everyone.
I've just finished the project. I got so many experiences here. This really works for us. I tried some modern properties like minmax() for layout but I couldn't use them properly, I'll try them later and I still couldn't solve the shaking problem. I think there are some strange properties in the design file like button's text position or cart positions etc. Should I push myself for that, are these the parts of the hard level challenge? If I push myself for these, my code will become non-readable. I don't want to change my clean version or there is a clear solution somewhere, idk.
I also have a major problem. How can I use the h1 tag on this page? Should I keep the pattern or can I add the h1 tag to some titles? Do I need a hierarchy here?
Thanks.
Any comments, critique, advice is greatly appreciated. For those of you reading this, have a nice day!
(Note: I separated style.css and media-queries.css for easy to read to code. I'll merge them later.)
Community feedback
- @ZMBAIGPosted almost 2 years ago
Hi,
Nice to complete this challenge, here is a sugessetion for your question about heading;
<strong class="article-card__title">Sedans</strong> <p class="article-card__description"> Choose a sedan for its affordability and excellent fuel economy. Ideal for cruising in the city or on your next road trip. </p>Replace <strong> with <h1> and you can adjust font-size in css. For further reading please visit the Heading.
I hope this will help you .
Well done and best of luck for the next challenge.
Marked as helpful1@adonmez04Posted almost 2 years ago@ZMBAIG Hi, thank you for your comment.
Yes, I have to add the h1 tag to the page but I'm not sure if I need a hierarchy here. I want to keep the same level for all of the iteration areas. I want to duplicate them forever in the same style. I'm very confused about this, maybe I should keep it simple and just add the h1 tag, but I really don't understand this situation :(
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord