FEM QR Code Components using SASS

Community feedback

• 

  cyber-m•140

  @cyber-mPosted about 1 month ago

  Hey Brandon! Great job!

  I noticed just couple of small details in the p tag styling. According to the Figma design file, it should include:

  letter-spacing: 0.2px; /* or with any alternative CSS unit e.g., rems (rem) */
  line-height: 140%;  /* should render as 21px it's slight smaller in your implementation */
  

  0

  ---

  

  Brandon J. Wells•30

  @dev-bjwellsPosted about 1 month ago

  Hi @cyber-m, thank you for your feedback. I actually didn't have access to the Figma Design file and created this using the static image and assets so it was tricky getting it to be exact. I did this based on personal experience and some guesses based on what I could see.

  0

  

  cyber-m•140

  @cyber-mPosted about 1 month ago

  Thanks for your reply, That's making sense, it's almost impossible to notice such a small detail if you don't have the Figma file. I don't have pro plan but I did get the design file, maybe at time you did the challenge it wasn't available.

  *I comment on your work as part of the "Getting started on Frontend Mentor" learning path, it randomly picked a solution to comment on.

  0