Feedback is welcome, made with css grid

Community feedback

• 

  Thomas Burette•190

  @tburettePosted 9 months ago

  Nice result and nice code!

  You use BEM. In your header there are classes for the modifiers but not the block. You have class="header__title but no class="header".

  To do the layout of the cards in the desktop layout you used a grid with three columns and four rows. What I did was that I had three columns and two rows. First and last card span the two rows. Middle two cards occupy their own row (+ some adjust toward the center). I find your solution simpler than mine.

  I also noticed that to have an item span one column you used grid-column-start: 1;. I didn't you could do that. I'm used to do grid-column: 1 / span 1;.

  I'm curious. Where does the css reset that you use come from?

  1

  ---

  

  JanAbe•230

  @JanAbePosted 9 months ago

  @tburette

  Ty for commenting!

  I used a BEM "inspired" naming convention because I only vaguely know what BEM is lol. Need to look that up some day soon and apply it property to my projects.

  The css reset I use comes from andy bell. https://piccalil.li/blog/a-more-modern-css-reset/

  It was recommended to me by a moderator on the discord server.

  0