Fast card component creation

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Mirko, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!

  👏 Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings. The background-color in this case is background-color: #D5E1EF

  1.This is the correct color for the background body { background-color: hsl(212deg 66% 92%);}

  2.The correct value for this shadow is box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

  3.I saw that you've used margins and position relative to give the container its alignment, this works but is really tricky to control all the content. My advice for you is to use flexbox to create this alignment. To make this alignment, first of all put min-height: 100vh to the body to make the body display 100% of the viewport height (this makes the container align to the height size thats now 100% of the screen height) size and display: flex e flex-direction: column to align the child element (the container) vertically using the body as reference.

  ✌️ I hope this helps you and happy coding!

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Good first attempt at the challenge. Just a few suggestion, to center the card on the page use th following:

  body {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  you can either add it directly or use the equivalent bootstrap class. Remove the background colors on the sections and add the background color on the body and a box shadow.

  To get rounded corners on the image remove the p-3 class and add it to the card container.

  Hope these are helpful.

  0