FAQs using HTML, CSS, JS

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  CSS and Styling:

  • Consider using a max-width for the div.box element, I used max-width: 600px
  • Implement CSS custom properties to define and utilize project colors more easily.
  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Ahmed Awad•80

  @AhmedAwad97Posted 11 months ago

  @AGutierrezR Hello Andrés , i appreciate your feedback, i am going to enhance my code

  0
• 

  Henry Seigbein•190

  @hensco95Posted 11 months ago

  Hello Ahmed. Amazing work, its really accessible. However I noticed a few things, whenever I expand a section from the accordion, the button(an image I suppose) vanishes, leaving only a broken img and an alt text of "mir". Asides that, you did well.

  Marked as helpful

  2

  ---

  

  Ahmed Awad•80

  @AhmedAwad97Posted 11 months ago

  @hensco95 Hello Henry, i dont know why this happens, i have written the path correct and the button is shown in the live server

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @AhmedAwad97!

  Your solution is excellent!

  I have one suggestion:

  • You don't need to create a separate section to get the background pattern correctly. You can use both background-color and background-image together. This will help you reduce unnecessary code.

  I hope it helps!

  Other than that, great job!

  0