Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I want to work more on JavaScript.
What challenges did you encounter, and how did you overcome them?The challenge was for me is accordion in javaScript. I overcome the challenge by using W3 Schools site.
What specific areas of your project would you like help with?A positive feedback is appreciated...!
Community feedback
- @calvinvinPosted 3 months ago
Works well!
I learned
Element.scrollHeightproperty from your code.A few small things I noted:
- the headings should be added by order for accessibility, i.e., not skip to
<h4>after<h1>. See MDN reference. - the source of font-family 'Work Sans' was not embedded, therefore not working.
- the way the accordion expands at both top and bottom direction when opening feels less convenient for me. I have to move my mouse cursor up to close the accordion after opening it. If the accordion title keeps at the same position, I can just click mouse again to close the accordion.
1 - the headings should be added by order for accessibility, i.e., not skip to
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord