FAQ-Accordion-Card-Solution-using-CSS-Flexbox-and-JavaScript
Design comparison
Solution retrospective
I welcome any feedback or suggestions that will help me improve my HTML, CSS, or JavaScript programs. Happy coding and thanks! 😊
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi, Pedro Castaneda! 👋
Good job on this challenge! 👏 Well done on "hiding" all the decorative images! 👍
I notice that you have some accessibility issues and HTML issues. I would recommend fixing those issues first.
After that, I would recommend using the native HTML elements to create the accordions,
summary
anddetails
tags. By default, they are accessible so the users of the screenreader will be able to know whether the accordion panel is expanded or collapsed. On the current HTML markup, there is no way for the screenreader users to know whether or not the accordion panel is expanded or collapsed.Hope this helps! 🙂
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord