faq-accordion-card-main

Community feedback

• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there👋!! Congratulations on completing this challange.

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

  📌 Image element do not have alt attributes or you leave it blank

  for example code

  <img src="images/image-qr-code.png">

  In this code you should add alt in your code

  <img 
    src="images/image-qr-code.png"   
    alt="qr code"
  >
  

  • This alt attribute provides alternative text for images, which is important for accessibility purposes. Screen readers, use the alt attribute to read out loud what the image is about, allowing visually impaired users to understand the content of the page.

  I hope you found this helpful! 😊

  Happy coding🤖

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main instead of height: 98vh. Setting the height: 98vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 98vh then the main will have 98vh height no matter what. Even if the content spans more than 98vh of viewport.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Felice Nicolas Barcellona•490

  @feliceNicolasBarcellonaPosted over 1 year ago

  thank you for the feedback

  0