faq-accordion-card-main (HTML, CSS ONLY)
Design comparison
Solution retrospective
I had some difficulties in using the background and some doubts about the grid, but I think it is average, but what I want is to always improve.
If you notice something wrong or you know a better way to do something please tell me XD Every feedback is important
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, just to point some things. I think it will be prettier to make your input tags? The ones that you made visibility hidden? Make it display none, even though display none is on, it will still function like :checked, cause when you visibility hidden, the item is hidden of course, but still leaves their space, there is still a box that is left out of the item that is hidden. Just make it display none so that no extra space will be used. Also your layout is kinda off in desktop? If you use min-width, from that resolution onwards, so your media of min-width: 1440px, only people with resolution higher than that will get the proper look. Try changin it to max-width or lower the resolution of the min width^^
0@GustavoMontPosted over 3 years ago@pikamart Actually I tought widths described on style-guide would be the min width to active the differents layout, so much that the in my computer, layout didn’t activate and I thought "This is wrong" hahahah. Thank you for this tips XD
0@pikapikamartPosted over 3 years ago@GustavoMont Oh that is the
max-width
. Want a tip? That max-width, is the whole itself. So what you do? Well at your body tag, set themax-width: 1440px
so that your design will be capped at 1440px, no overflow and fixed. Thenmargin: 0 auto
so that your body, or the whole design or page itself, when it reached the maximum widtth, it will be centered and nice looking^^0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord