FAQ-accordion-card-component using : HTML, CSS, SASS
Design comparison
Solution retrospective
Please give your feedback and review my code and design !! I have tried my best to design as close as possible to the given challenge. I would really appreciate your feedback.
Thank-You !! Parth :)
Community feedback
- @dwhensonPosted over 3 years ago
Hey @ParthPatel76 Good work on this one - it's a tricky one for sure!! Your page looks good and responds well at smaller screens which is great! π
Here's some points you might like to consider:
-
Firstly good job making this work with no JS! My only suggestion would be that the sections should expand on a click rather than hover, and that some transition would be nice here as it's quite abrupt at the moment.
-
One way to make this all much easier is to check out the
details
andsummary
elements. These have a lot of the functionality you are looking for built it. This will make it easier to change things on click rather than hover. -
You also add some opening transitions or even a simple animation to make things look smooth if you really wanted to make things look good. And again you can do all this without JS and it will help with some CSS selector practice!
Finally, just to say nice work on the image positioning. This is something I really struggle with but you seem to have done a great job here! π
Hope this helps and keep up the good work!! π
1@ParthPatel76Posted over 3 years ago@dwhenson
Hey, thanks for such a great feedback, I really appreciate it.π I will definitely make the required improvements, considering your suggestions.
Thanks, Parthπ
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord