FAQ-Accordion-Card

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your buttons should have an aria-expanded and this should be used to open and close the accordion.

  • Your JS is unnecessarily overcomplicated ⚠️. At max it should only be 13 lines of code.

  • Your content is not responsive ⚠️. Anything under 1000px and the side of your content get cut off and continue as the screen size shrinks.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  1

  ---

  

  Yakeru•260

  @ykru6Posted over 1 year ago

  @vcarames Hello! Sorry for replying in such a long time. May you suggest me how can my JS be more concise just as 13 lines of code you said? And does the "unnecessarily over-complicated" avoidable by any means (in general)? What knowledge or concept am I missing out?

  0

  

  Yakeru•260

  @ykru6Posted over 1 year ago

  @vcarames Second One other thing that I wanted to know is how would you approach this problem and how would you dissect it? And is there a skill that I can learn to pinpoint the crucial parts of the problem and weed out unnecessary things?

  0