FAQ-accordion-card using HTML/CSS/Vanilla JS
Design comparison
Solution retrospective
Any suggestions to help me improve are appreciated
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Mohamed Lebda, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that the is not centralized to solve this we can do the following:
body { margin: 0; padding: 0; display: flex; align-items: center; flex-direction: column; justify-content: center; min-height: 100vh; }
Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord